Kharec/urupam
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: tighten integration gating

Browse Source
This commit is contained in:
Sandro CURY CAZZANIGA
2026-01-15 11:57:12 +01:00
parent 17eb69fed0
commit 77a45cc58e
1 changed files with 58 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

146
t/integration.t
View File

@@ -6,6 +6,18 @@ my $t;
eval { $t = Test::Mojo->new('Urupam::App'); 1 } eval { $t = Test::Mojo->new('Urupam::App'); 1 }
or plan skip_all => "Test server not available: $@"; or plan skip_all => "Test server not available: $@";
sub wait_promise {
my ($promise) = @_;
my ( $value, $error );
$promise->then( sub { $value = shift } )
->catch( sub { $error = shift } )
->wait;
return ( $value, $error );
}
my ( $pong, $ping_err ) = wait_promise( $t->app->db->ping );
plan skip_all => "Redis not available: $ping_err" if $ping_err;
my $CODE_PATTERN = qr/^[0-9a-zA-Z\-_]+$/; my $CODE_PATTERN = qr/^[0-9a-zA-Z\-_]+$/;
my $CODE_LENGTH = 12; my $CODE_LENGTH = 12;
my $MAX_URL_LENGTH = 2048; my $MAX_URL_LENGTH = 2048;
@@ -18,6 +30,12 @@ sub validate_short_code_format {
&& $code =~ $CODE_PATTERN; && $code =~ $CODE_PATTERN;
} }
sub expected_normalized_url {
my ($url) = @_;
return $url if defined $url && $url =~ m{^https?://}i;
return defined $url ? "http://$url" : undef;
}
sub post_shorten { sub post_shorten {
my ($url) = @_; my ($url) = @_;
my $tx = $t->post_ok( '/api/v1/urls' => json => { url => $url } ); my $tx = $t->post_ok( '/api/v1/urls' => json => { url => $url } );
@@ -52,6 +70,8 @@ sub validate_shorten_response {
"$label: short code valid" ); "$label: short code valid" );
is( length( $json->{short_code} ), is( length( $json->{short_code} ),
$CODE_LENGTH, "$label: short code length correct" ); $CODE_LENGTH, "$label: short code length correct" );
is( $json->{original_url}, $url, "$label: original URL matches" )
if defined $url;
like( like(
$json->{short_url}, $json->{short_url},
qr/^https?:\/\/[^\/]+\/$json->{short_code}$/, qr/^https?:\/\/[^\/]+\/$json->{short_code}$/,
@@ -81,39 +101,20 @@ sub validate_get_response {
return 1; return 1;
} }
sub skip_if_error {
my ( $res, $context ) = @_;
if ( $res->{code} != 200 && $res->{code} != 400 && $res->{code} != 404 ) {
diag( "$context skipped: " . $res->{error} );
return 1;
}
return 0;
}
subtest 'POST /api/v1/urls - Real validator success cases' => sub { subtest 'POST /api/v1/urls - Real validator success cases' => sub {
for my $url ( 'https://www.example.com', 'http://www.perl.org' ) { for my $url ( 'https://www.example.com', 'http://www.perl.org' ) {
my $res = post_shorten($url); my $res = post_shorten($url);
if ( $res->{code} == 200 ) { is( $res->{code}, 200, "URL accepted: $url" );
validate_shorten_response( $res, $url, "URL: $url" ); validate_shorten_response( $res, $url, "URL: $url" );
} }
else {
diag( "Test skipped for $url: " . $res->{error} );
}
}
}; };
subtest 'POST /api/v1/urls - Real validator URL normalization' => sub { subtest 'POST /api/v1/urls - Real validator URL normalization' => sub {
for my $input ( 'www.example.com', 'example.com' ) { for my $input ( 'www.example.com', 'example.com' ) {
my $res = post_shorten($input); my $res = post_shorten($input);
if ( $res->{code} == 200 ) { is( $res->{code}, 200, "URL normalized: $input" );
like( $res->{json}->{original_url}, my $expected = expected_normalized_url($input);
qr/^https?:\/\//, "URL normalized: $input" ); validate_shorten_response( $res, $expected, "URL normalized: $input" );
ok( validate_short_code_format( $res->{json}->{short_code} ),
"Code generated for: $input" );
}
else {
diag( "Normalization test skipped for $input: " . $res->{error} );
}
} }
}; };
@@ -139,21 +140,11 @@ subtest 'POST /api/v1/urls - Real validator network errors (async)' => sub {
my $url ( 'http://nonexistent-domain-12345.invalid', 'http://192.0.2.1' ) my $url ( 'http://nonexistent-domain-12345.invalid', 'http://192.0.2.1' )
{ {
my $res = post_shorten($url); my $res = post_shorten($url);
ok( is( $res->{code}, 200, "Network URL accepted asynchronously: $url" );
$res->{code} == 200 || $res->{code} == 400, validate_shorten_response( $res, $url, "URL: $url" );
"Network URL accepted or rejected by format: $url"
);
} }
}; };
subtest 'POST /api/v1/urls - Real validator SSL certificate validation' => sub {
my $res = post_shorten('https://www.example.com');
ok(
$res->{code} == 200 || $res->{code} == 400,
'SSL validation runs async for HTTPS URL'
);
};
subtest 'POST /api/v1/urls - Real validator invalid URL format' => sub { subtest 'POST /api/v1/urls - Real validator invalid URL format' => sub {
for my $case ( for my $case (
{ url => 'ftp://example.com', error => 'Invalid URL format' }, { url => 'ftp://example.com', error => 'Invalid URL format' },
@@ -165,10 +156,13 @@ subtest 'POST /api/v1/urls - Real validator invalid URL format' => sub {
is( $res->{error}, $case->{error}, "Correct error for: $case->{url}" ); is( $res->{error}, $case->{error}, "Correct error for: $case->{url}" );
} }
};
subtest 'POST /api/v1/urls - Real validator bare hostname' => sub {
my $res = post_shorten('not-a-url'); my $res = post_shorten('not-a-url');
is( $res->{code}, 200, 'Bare hostname accepted: not-a-url' ); is( $res->{code}, 200, 'Bare hostname accepted: not-a-url' );
like( $res->{json}->{original_url}, validate_shorten_response( $res, 'http://not-a-url',
qr{^http://not-a-url$}, 'Bare hostname normalized with scheme' ); 'Bare hostname normalized' );
}; };
subtest 'POST /api/v1/urls - Real validator URL length validation' => sub { subtest 'POST /api/v1/urls - Real validator URL length validation' => sub {
@@ -191,15 +185,8 @@ subtest 'POST /api/v1/urls - Real validator URL edge cases' => sub {
) )
{ {
my $res = post_shorten($url); my $res = post_shorten($url);
if ( $res->{code} == 200 ) { is( $res->{code}, 200, "Edge case handled: $url" );
ok( validate_short_code_format( $res->{json}->{short_code} ), validate_shorten_response( $res, $url, "Edge case handled: $url" );
"Edge case handled: $url" );
like( $res->{json}->{original_url},
qr/^https?:\/\//, "URL format preserved: $url" );
}
else {
diag( "Edge case test skipped for $url: " . $res->{error} );
}
} }
}; };
@@ -207,34 +194,26 @@ subtest 'POST /api/v1/urls - Real database persistence and retrieval' => sub {
my $url = 'https://www.example.com'; my $url = 'https://www.example.com';
my $res1 = post_shorten($url); my $res1 = post_shorten($url);
if ( $res1->{code} == 200 ) { is( $res1->{code}, 200, 'Database write succeeded' );
my $code = $res1->{json}->{short_code}; my $code = $res1->{json}->{short_code};
ok( validate_short_code_format($code), 'Code generated and stored' ); ok( validate_short_code_format($code), 'Code generated and stored' );
my $res2 = get_url($code); my $res2 = get_url($code);
if ( $res2->{code} == 200 ) { is( $res2->{code}, 200, 'Database read succeeded' );
validate_get_response( $res2, $url, $code, 'Database retrieval' ); validate_get_response( $res2, $url, $code, 'Database retrieval' );
pass('Database persistence verified'); pass('Database persistence verified');
}
else {
diag( "Database retrieval failed: " . $res2->{error} );
}
}
else {
diag( "Database persistence test skipped: " . $res1->{error} );
}
}; };
subtest 'POST /api/v1/urls - Real database duplicate URL handling' => sub { subtest 'POST /api/v1/urls - Real database duplicate URL handling' => sub {
my $url = 'https://www.example.com'; my $url = 'https://www.example.com';
my $res1 = post_shorten($url); my $res1 = post_shorten($url);
if ( $res1->{code} == 200 ) { is( $res1->{code}, 200, 'First create succeeded' );
my $code1 = $res1->{json}->{short_code}; my $code1 = $res1->{json}->{short_code};
ok( validate_short_code_format($code1), 'First code generated' ); ok( validate_short_code_format($code1), 'First code generated' );
my $res2 = post_shorten($url); my $res2 = post_shorten($url);
if ( $res2->{code} == 200 ) { is( $res2->{code}, 200, 'Second create succeeded' );
my $code2 = $res2->{json}->{short_code}; my $code2 = $res2->{json}->{short_code};
ok( validate_short_code_format($code2), 'Second code generated' ); ok( validate_short_code_format($code2), 'Second code generated' );
ok( $code1 ne $code2, 'Duplicate URLs generate different codes' ); ok( $code1 ne $code2, 'Duplicate URLs generate different codes' );
@@ -242,21 +221,13 @@ subtest 'POST /api/v1/urls - Real database duplicate URL handling' => sub {
my $get1 = get_url($code1); my $get1 = get_url($code1);
my $get2 = get_url($code2); my $get2 = get_url($code2);
if ( $get1->{code} == 200 && $get2->{code} == 200 ) { is( $get1->{code}, 200, 'First code retrieves' );
is( $get2->{code}, 200, 'Second code retrieves' );
is( $get1->{json}->{original_url}, is( $get1->{json}->{original_url},
$url, 'First code retrieves original URL' ); $url, 'First code retrieves original URL' );
is( $get2->{json}->{original_url}, is( $get2->{json}->{original_url},
$url, 'Second code retrieves original URL' ); $url, 'Second code retrieves original URL' );
pass('Both codes persist and retrieve same URL'); pass('Both codes persist and retrieve same URL');
}
}
else {
diag( "Duplicate URL test skipped: " . $res2->{error} );
}
}
else {
diag( "Duplicate URL test skipped: " . $res1->{error} );
}
}; };
subtest 'GET /api/v1/urls/:short_code - Real database error cases' => sub { subtest 'GET /api/v1/urls/:short_code - Real database error cases' => sub {
@@ -280,43 +251,4 @@ subtest 'GET /api/v1/urls/:short_code - Real database error cases' => sub {
); );
}; };
subtest 'End-to-end: Full flow with real components' => sub {
for my $url ( 'https://www.example.com', 'http://www.perl.org' ) {
my $res1 = post_shorten($url);
if ( $res1->{code} == 200 ) {
my $code = $res1->{json}->{short_code};
ok( validate_short_code_format($code), "Code generated for: $url" );
my $res2 = get_url($code);
if ( $res2->{code} == 200 ) {
validate_get_response( $res2, $url, $code, "End-to-end: $url" );
}
else {
diag( "End-to-end GET failed for $url: " . $res2->{error} );
}
}
else {
diag( "End-to-end POST failed for $url: " . $res1->{error} );
}
}
};
subtest 'Real database connection test' => sub {
my $res = post_shorten('https://www.example.com');
if ( $res->{code} == 200 ) {
pass('Database connection successful (Redis accessible)');
my $get_res = get_url( $res->{json}->{short_code} );
pass('Database read operation successful') if $get_res->{code} == 200;
}
elsif ( $res->{code} == 400 && $res->{error} =~ /Database error/i ) {
diag( "Database connection test: Redis may not be available - "
. $res->{error} );
}
else {
diag( "Database connection test skipped: " . $res->{error} );
}
};
done_testing(); done_testing();