Kharec/urupam
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prevent double-rendering in async promise chains

Browse Source
This commit is contained in:
Sandro CURY CAZZANIGA
2025-12-28 17:28:53 +01:00
parent 7d46eb3922
commit 40b848eeee
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Urupam/API.pm
View File

@@ -29,7 +29,7 @@ sub shorten {
} }
my $normalized_url; my $normalized_url;
$validator->validate_url_with_checks($original_url)->then( return $validator->validate_url_with_checks($original_url)->then(
sub { sub {
my $sanitized_url = shift; my $sanitized_url = shift;
$normalized_url = $sanitized_url; $normalized_url = $sanitized_url;
@@ -38,7 +38,8 @@ sub shorten {
)->then( )->then(
sub { sub {
my $short_code = shift; my $short_code = shift;
my $short_url = $c->url_for("/$short_code")->to_abs; return if $c->stash->{rendered};
my $short_url = $c->url_for("/$short_code")->to_abs;
$c->render( $c->render(
json => { json => {
success => 1, success => 1,
@@ -51,6 +52,7 @@ sub shorten {
)->catch( )->catch(
sub { sub {
my $err = shift; my $err = shift;
return if $c->stash->{rendered};
$c->app->log->error("API URL validation/creation error: $err"); $c->app->log->error("API URL validation/creation error: $err");
my $status = get_error_status($err); my $status = get_error_status($err);
my $sanitized_error = sanitize_error_message($err); my $sanitized_error = sanitize_error_message($err);
@@ -77,9 +79,10 @@ sub get_url {
return; return;
} }
$url_service->get_original_url($short_code)->then( return $url_service->get_original_url($short_code)->then(
sub { sub {
my $original_url = shift; my $original_url = shift;
return if $c->stash->{rendered};
if ($original_url) { if ($original_url) {
my $short_url = $c->url_for("/$short_code")->to_abs; my $short_url = $c->url_for("/$short_code")->to_abs;
$c->render( $c->render(
@@ -101,6 +104,7 @@ sub get_url {
)->catch( )->catch(
sub { sub {
my $err = shift; my $err = shift;
return if $c->stash->{rendered};
$c->app->log->error("API URL retrieval error: $err"); $c->app->log->error("API URL retrieval error: $err");
my $status = get_error_status($err); my $status = get_error_status($err);
my $sanitized_error = sanitize_error_message($err); my $sanitized_error = sanitize_error_message($err);