Kharec/urupam
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: align async validation tests

Browse Source
This commit is contained in:
Sandro CURY CAZZANIGA
2026-01-05 07:22:13 +01:00
parent 777b589946
commit 385084afc5
1 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
t/06_validation.t
View File

@@ -93,6 +93,10 @@ sub with_subprocess_stub {
return $code->(); return $code->();
} }
sub clear_validation_caches {
$validator->_clear_caches;
}
subtest 'is_valid_url_length' => sub { subtest 'is_valid_url_length' => sub {
ok( $validator->is_valid_url_length('http://example.com'), ok( $validator->is_valid_url_length('http://example.com'),
'valid URL length passes' ); 'valid URL length passes' );
@@ -345,6 +349,7 @@ subtest 'validate_short_code' => sub {
}; };
subtest 'check_url_reachable - success codes' => sub { subtest 'check_url_reachable - success codes' => sub {
clear_validation_caches();
for my $code ( 200, 201 ) { for my $code ( 200, 201 ) {
with_ssrf_ua( with_ssrf_ua(
mock_ua_with_code($code), mock_ua_with_code($code),
@@ -359,6 +364,7 @@ subtest 'check_url_reachable - success codes' => sub {
}; };
subtest 'check_url_reachable - error codes' => sub { subtest 'check_url_reachable - error codes' => sub {
clear_validation_caches();
my @cases = ( my @cases = (
[ 410, qr/URL returned 410 error/, '4xx status returns error' ], [ 410, qr/URL returned 410 error/, '4xx status returns error' ],
[ 500, qr/URL returned 500 error/, '5xx status returns error' ], [ 500, qr/URL returned 500 error/, '5xx status returns error' ],
@@ -366,11 +372,12 @@ subtest 'check_url_reachable - error codes' => sub {
); );
for my $case (@cases) { for my $case (@cases) {
my $url = "http://example.com/$case->[0]";
with_ssrf_ua( with_ssrf_ua(
mock_ua_with_code( $case->[0] ), mock_ua_with_code( $case->[0] ),
sub { sub {
my ( $result, $error ) = wait_promise( my ( $result, $error ) =
$validator->check_url_reachable('http://example.com') ); wait_promise( $validator->check_url_reachable($url) );
is( $result, undef, "$case->[0] status has no result" ); is( $result, undef, "$case->[0] status has no result" );
like( $error, $case->[1], $case->[2] ); like( $error, $case->[1], $case->[2] );
} }
@@ -379,6 +386,7 @@ subtest 'check_url_reachable - error codes' => sub {
}; };
subtest 'check_url_reachable - HEAD fallback to GET' => sub { subtest 'check_url_reachable - HEAD fallback to GET' => sub {
clear_validation_caches();
my $mock_ua = Test::MockObject->new; my $mock_ua = Test::MockObject->new;
my $head_tx = Test::MockObject->new; my $head_tx = Test::MockObject->new;
my $head_result = Test::MockObject->new; my $head_result = Test::MockObject->new;
@@ -418,6 +426,7 @@ subtest 'check_url_reachable - HEAD fallback to GET' => sub {
}; };
subtest 'check_url_reachable - HEAD fallback error' => sub { subtest 'check_url_reachable - HEAD fallback error' => sub {
clear_validation_caches();
my $mock_ua = Test::MockObject->new; my $mock_ua = Test::MockObject->new;
my $head_tx = Test::MockObject->new; my $head_tx = Test::MockObject->new;
my $head_result = Test::MockObject->new; my $head_result = Test::MockObject->new;
@@ -457,6 +466,7 @@ subtest 'check_url_reachable - HEAD fallback error' => sub {
}; };
subtest 'check_url_reachable - classified errors' => sub { subtest 'check_url_reachable - classified errors' => sub {
clear_validation_caches();
my @cases = ( my @cases = (
[ [
'Name or service not known', 'Name or service not known',
@@ -481,6 +491,7 @@ subtest 'check_url_reachable - classified errors' => sub {
); );
for my $case (@cases) { for my $case (@cases) {
clear_validation_caches();
with_ssrf_ua( with_ssrf_ua(
mock_ua_with_error( $case->[0] ), mock_ua_with_error( $case->[0] ),
sub { sub {
@@ -728,9 +739,8 @@ subtest 'validate_url_with_checks - SSL check failure' => sub {
} }
); );
is( $result, undef, 'SSL check failure has no result' ); is( $result, 'https://example.com', 'SSL check failure is async' );
like( $error, qr/Invalid SSL certificate/, is( $error, undef, 'SSL check async has no error' );
'SSL check failure is detected' );
}; };
subtest 'validate_url_with_checks - reachability check failure' => sub { subtest 'validate_url_with_checks - reachability check failure' => sub {
@@ -769,12 +779,8 @@ subtest 'validate_url_with_checks - reachability check failure' => sub {
} }
); );
is( $result, undef, 'reachability failure has no result' ); is( $result, 'https://example.com', 'reachability failure is async' );
like( is( $error, undef, 'reachability async has no error' );
$error,
qr/Cannot reach URL/,
'reachability check failure is detected'
);
}; };
done_testing(); done_testing();