From 78289891503ccadc854beff039e69754503977e8 Mon Sep 17 00:00:00 2001 From: Kharec Date: Tue, 30 Dec 2025 08:45:39 +0100 Subject: [PATCH] refactor: dedupe file handler cleanup in setup_logger --- skywipe/logger.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/skywipe/logger.py b/skywipe/logger.py index d3adf7f..2212cab 100644 --- a/skywipe/logger.py +++ b/skywipe/logger.py @@ -67,10 +67,11 @@ def setup_logger(verbose: bool = False, log_file: Path | None = None) -> logging error_handler.setFormatter(formatter) logger.addHandler(error_handler) + for handler in file_handlers: + handler.close() + logger.removeHandler(handler) + if log_file: - for handler in file_handlers: - handler.close() - logger.removeHandler(handler) log_file.parent.mkdir(parents=True, exist_ok=True) file_handler = logging.FileHandler(log_file, encoding="utf-8") file_handler.setLevel(logging.DEBUG) @@ -80,10 +81,6 @@ def setup_logger(verbose: bool = False, log_file: Path | None = None) -> logging ) file_handler.setFormatter(file_formatter) logger.addHandler(file_handler) - else: - for handler in file_handlers: - handler.close() - logger.removeHandler(handler) return logger