chore: remove marian's duplicate installation check
marian.Installed and marian.Files were only used by the package's own test, while the app has its own check in translation.go - with a different rule (pinned size there, size > 0 here), so the two definitions of 'installed' could disagree. The app's check is the canonical one (it owns the pins); Load already fails on an incomplete model, which the test keeps asserting.
This commit is contained in:
1 parent
1440adc199
commit
e85d0ba7e9
3 files changed
-19
No files matched your search
@@ -251,9 +251,6 @@ func tinyModel(t *testing.T) string {
|
||||
|
||||
func TestTinyModel(t *testing.T) {
|
||||
dir := tinyModel(t)
|
||||
if !Installed(dir) {
|
||||
t.Fatal("tiny model not installed")
|
||||
}
|
||||
m, err := Load(context.Background(), dir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
@@ -281,9 +278,6 @@ func TestTinyModel(t *testing.T) {
|
||||
}
|
||||
|
||||
os.Remove(filepath.Join(dir, "vocab.json"))
|
||||
if Installed(dir) {
|
||||
t.Error("incomplete model reported installed")
|
||||
}
|
||||
if _, err := Load(context.Background(), dir); err == nil {
|
||||
t.Error("incomplete model loaded")
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user