Kharec/goyco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: Kharec:4eb0a6360f88ea94a358953b25f7c072a5570fad
Branches Tags
Kharec:main
..
compare: Kharec:31ef30c9413c784297b7a4611444badbfdde354e
Branches Tags
Kharec:main

2 Commits
4eb0a6360f ... 31ef30c941

Author SHA1 Message Date
Kharec
31ef30c941 test(health): expect unhealthy for SMTP connection failures 2026-02-16 08:43:46 +01:00
Kharec
d4a89325e0 fix(health): mark SMTP connection/bootstrap failures as unhealthy 2026-02-16 08:43:33 +01:00
2 changed files with 6 additions and 6 deletions
Expand all files Collapse all files

4
internal/health/smtp.go
View File

@@ -45,7 +45,7 @@ func (c *SMTPChecker) Check(ctx context.Context) Result {
conn, err := net.Dial("tcp", address) conn, err := net.Dial("tcp", address)
if err != nil { if err != nil {
result.Status = StatusDegraded result.Status = StatusUnhealthy
result.Message = fmt.Sprintf("Failed to connect to SMTP server: %v", err) result.Message = fmt.Sprintf("Failed to connect to SMTP server: %v", err)
result.Latency = time.Since(start) result.Latency = time.Since(start)
return result return result
@@ -54,7 +54,7 @@ func (c *SMTPChecker) Check(ctx context.Context) Result {
client, err := smtp.NewClient(conn, c.config.Host) client, err := smtp.NewClient(conn, c.config.Host)
if err != nil { if err != nil {
result.Status = StatusDegraded result.Status = StatusUnhealthy
result.Message = fmt.Sprintf("Failed to create SMTP client: %v", err) result.Message = fmt.Sprintf("Failed to create SMTP client: %v", err)
result.Latency = time.Since(start) result.Latency = time.Since(start)
return result return result

8
internal/health/smtp_test.go
View File

@@ -36,8 +36,8 @@ func TestSMTPChecker_Check_InvalidPort(t *testing.T) {
result := checker.Check(ctx) result := checker.Check(ctx)
if result.Status != StatusDegraded { if result.Status != StatusUnhealthy {
t.Errorf("expected degraded status for invalid port, got %s", result.Status) t.Errorf("expected unhealthy status for invalid port, got %s", result.Status)
} }
} }
@@ -59,8 +59,8 @@ func TestSMTPChecker_Check_ConnectionRefused(t *testing.T) {
result := checker.Check(ctx) result := checker.Check(ctx)
if result.Status != StatusDegraded { if result.Status != StatusUnhealthy {
t.Errorf("expected degraded status for connection refused, got %s", result.Status) t.Errorf("expected unhealthy status for connection refused, got %s", result.Status)
} }
} }