Kharec/goyco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove redundant validation, trust middleware and service layer

Browse Source
This commit is contained in:
Sandro CURY CAZZANIGA
2026-01-10 22:41:54 +01:00
parent a1e63b868f
commit a1466e860d
1 changed files with 0 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
internal/handlers/auth_handler.go
View File

@@ -124,20 +124,6 @@ func (h *AuthHandler) Register(w http.ResponseWriter, r *http.Request) {
password := strings.TrimSpace(req.Password) password := strings.TrimSpace(req.Password)
username = security.SanitizeUsername(username) username = security.SanitizeUsername(username)
if err := validation.ValidateUsername(username); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
if err := validation.ValidateEmail(email); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
if err := validation.ValidatePassword(password); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
result, err := h.authService.Register(username, email, password) result, err := h.authService.Register(username, email, password)
if err != nil { if err != nil {
@@ -313,11 +299,6 @@ func (h *AuthHandler) ResetPassword(w http.ResponseWriter, r *http.Request) {
return return
} }
if err := validation.ValidatePassword(newPassword); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
if err := h.authService.ResetPassword(token, newPassword); err != nil { if err := h.authService.ResetPassword(token, newPassword); err != nil {
switch { switch {
case strings.Contains(err.Error(), "expired"): case strings.Contains(err.Error(), "expired"):
@@ -360,10 +341,6 @@ func (h *AuthHandler) UpdateEmail(w http.ResponseWriter, r *http.Request) {
} }
email := strings.TrimSpace(req.Email) email := strings.TrimSpace(req.Email)
if err := validation.ValidateEmail(email); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
user, err := h.authService.UpdateEmail(userID, email) user, err := h.authService.UpdateEmail(userID, email)
if err != nil { if err != nil {
@@ -410,10 +387,6 @@ func (h *AuthHandler) UpdateUsername(w http.ResponseWriter, r *http.Request) {
} }
username := strings.TrimSpace(req.Username) username := strings.TrimSpace(req.Username)
if err := validation.ValidateUsername(username); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
user, err := h.authService.UpdateUsername(userID, username) user, err := h.authService.UpdateUsername(userID, username)
if err != nil { if err != nil {
@@ -457,16 +430,6 @@ func (h *AuthHandler) UpdatePassword(w http.ResponseWriter, r *http.Request) {
currentPassword := strings.TrimSpace(req.CurrentPassword) currentPassword := strings.TrimSpace(req.CurrentPassword)
newPassword := strings.TrimSpace(req.NewPassword) newPassword := strings.TrimSpace(req.NewPassword)
if currentPassword == "" {
SendErrorResponse(w, "Current password is required", http.StatusBadRequest)
return
}
if err := validation.ValidatePassword(newPassword); err != nil {
SendErrorResponse(w, err.Error(), http.StatusBadRequest)
return
}
user, err := h.authService.UpdatePassword(userID, currentPassword, newPassword) user, err := h.authService.UpdatePassword(userID, currentPassword, newPassword)
if err != nil { if err != nil {
if strings.Contains(err.Error(), "current password is incorrect") { if strings.Contains(err.Error(), "current password is incorrect") {