Kharec/goyco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: replace if/else chain with switch statement

Browse Source
This commit is contained in:
Sandro CURY CAZZANIGA
2025-11-14 06:59:47 +01:00
parent e171776055
commit 9dfef1d67f
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/e2e/static_files_test.go
View File

@@ -25,7 +25,8 @@ func TestE2E_StaticFileServing(t *testing.T) {
} }
defer resp.Body.Close() defer resp.Body.Close()
if resp.StatusCode == http.StatusOK { switch resp.StatusCode {
case http.StatusOK:
contentType := resp.Header.Get("Content-Type") contentType := resp.Header.Get("Content-Type")
if !strings.Contains(contentType, "text/css") && !strings.Contains(contentType, "application/octet-stream") { if !strings.Contains(contentType, "text/css") && !strings.Contains(contentType, "application/octet-stream") {
t.Logf("Unexpected Content-Type for CSS file: %s", contentType) t.Logf("Unexpected Content-Type for CSS file: %s", contentType)
@@ -39,9 +40,9 @@ func TestE2E_StaticFileServing(t *testing.T) {
if len(body) == 0 { if len(body) == 0 {
t.Error("Static CSS file is empty") t.Error("Static CSS file is empty")
} }
} else if resp.StatusCode == http.StatusNotFound { case http.StatusNotFound:
t.Log("Static CSS file not found (may not exist in test environment)") t.Log("Static CSS file not found (may not exist in test environment)")
} else { default:
t.Errorf("Expected status 200 or 404, got %d", resp.StatusCode) t.Errorf("Expected status 200 or 404, got %d", resp.StatusCode)
} }
}) })
@@ -95,12 +96,13 @@ func TestE2E_StaticFileServing(t *testing.T) {
} }
defer resp.Body.Close() defer resp.Body.Close()
if resp.StatusCode == http.StatusOK { switch resp.StatusCode {
case http.StatusOK:
contentType := resp.Header.Get("Content-Type") contentType := resp.Header.Get("Content-Type")
if !strings.Contains(contentType, "image") && !strings.Contains(contentType, "application/octet-stream") { if !strings.Contains(contentType, "image") && !strings.Contains(contentType, "application/octet-stream") {
t.Logf("Unexpected Content-Type for favicon: %s", contentType) t.Logf("Unexpected Content-Type for favicon: %s", contentType)
} }
} else if resp.StatusCode == http.StatusNotFound { case http.StatusNotFound:
t.Log("Favicon not found (may not exist in test environment)") t.Log("Favicon not found (may not exist in test environment)")
} }
}) })