fix: modify compression middleware to pass through redirects immediately without buffering
This commit is contained in:
@@ -38,6 +38,10 @@ func CompressionMiddlewareWithConfig(config *CompressionConfig) func(http.Handle
|
|||||||
|
|
||||||
next.ServeHTTP(bufferedWriter, r)
|
next.ServeHTTP(bufferedWriter, r)
|
||||||
|
|
||||||
|
if bufferedWriter.isRedirect {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
if buf.Len() < config.MinSize {
|
if buf.Len() < config.MinSize {
|
||||||
bufferedWriter.flush()
|
bufferedWriter.flush()
|
||||||
w.Write(buf.Bytes())
|
w.Write(buf.Bytes())
|
||||||
@@ -73,9 +77,13 @@ type bufferedResponseWriter struct {
|
|||||||
buffer *bytes.Buffer
|
buffer *bytes.Buffer
|
||||||
statusCode int
|
statusCode int
|
||||||
headerWritten bool
|
headerWritten bool
|
||||||
|
isRedirect bool
|
||||||
}
|
}
|
||||||
|
|
||||||
func (brw *bufferedResponseWriter) Write(b []byte) (int, error) {
|
func (brw *bufferedResponseWriter) Write(b []byte) (int, error) {
|
||||||
|
if brw.isRedirect {
|
||||||
|
return brw.ResponseWriter.Write(b)
|
||||||
|
}
|
||||||
if !brw.headerWritten {
|
if !brw.headerWritten {
|
||||||
brw.statusCode = http.StatusOK
|
brw.statusCode = http.StatusOK
|
||||||
}
|
}
|
||||||
@@ -87,6 +95,11 @@ func (brw *bufferedResponseWriter) WriteHeader(code int) {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
brw.statusCode = code
|
brw.statusCode = code
|
||||||
|
if isRedirect(code) {
|
||||||
|
brw.isRedirect = true
|
||||||
|
brw.ResponseWriter.WriteHeader(code)
|
||||||
|
brw.headerWritten = true
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (brw *bufferedResponseWriter) Header() http.Header {
|
func (brw *bufferedResponseWriter) Header() http.Header {
|
||||||
@@ -100,6 +113,10 @@ func (brw *bufferedResponseWriter) flush() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func isRedirect(statusCode int) bool {
|
||||||
|
return statusCode >= 300 && statusCode < 400
|
||||||
|
}
|
||||||
|
|
||||||
func shouldCompress(r *http.Request, config *CompressionConfig) bool {
|
func shouldCompress(r *http.Request, config *CompressionConfig) bool {
|
||||||
return r.Header.Get("Content-Encoding") == ""
|
return r.Header.Get("Content-Encoding") == ""
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user