Kharec/goyco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: simplify else-if branches

Browse Source
This commit is contained in:
Sandro CURY CAZZANIGA
2026-01-07 17:16:02 +01:00
parent 73930dabd8
commit 1b55c9543e
1 changed files with 12 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
internal/config/config_test.go
View File

@@ -231,10 +231,8 @@ func TestValidateJWTSecret(t *testing.T) {
if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) { if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) {
t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error()) t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error())
} }
} else { } else if err != nil {
if err != nil { t.Fatalf("unexpected error for secret %q: %v", tt.secret, err)
t.Fatalf("unexpected error for secret %q: %v", tt.secret, err)
}
} }
}) })
} }
@@ -497,10 +495,8 @@ func TestValidateJWTConfig(t *testing.T) {
if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) { if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) {
t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error()) t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error())
} }
} else { } else if err != nil {
if err != nil { t.Fatalf("unexpected error for config %+v: %v", tt.config, err)
t.Fatalf("unexpected error for config %+v: %v", tt.config, err)
}
} }
}) })
} }
@@ -626,10 +622,8 @@ func TestLoadWithInvalidJWTConfig(t *testing.T) {
if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) { if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) {
t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error()) t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error())
} }
} else { } else if err != nil {
if err != nil { t.Fatalf("unexpected error: %v", err)
t.Fatalf("unexpected error: %v", err)
}
} }
}) })
} }
@@ -912,10 +906,8 @@ func TestValidateBcryptCost(t *testing.T) {
if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) { if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) {
t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error()) t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error())
} }
} else { } else if err != nil {
if err != nil { t.Fatalf("unexpected error for BCRYPT_COST %d: %v", tt.bcryptCost, err)
t.Fatalf("unexpected error for BCRYPT_COST %d: %v", tt.bcryptCost, err)
}
} }
}) })
} }
@@ -976,17 +968,14 @@ func TestLoadWithInvalidBcryptCost(t *testing.T) {
if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) { if tt.errorMsg != "" && !strings.Contains(err.Error(), tt.errorMsg) {
t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error()) t.Fatalf("expected error message to contain %q, got %q", tt.errorMsg, err.Error())
} }
} else if err != nil {
t.Fatalf("unexpected error: %v", err)
} else { } else {
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
expectedCost := 12 expectedCost := 12
if tt.bcryptCost == "" { if tt.bcryptCost == "" {
expectedCost = 10 expectedCost = 10
} else { } else if costInt, err := strconv.Atoi(tt.bcryptCost); err == nil {
if costInt, err := strconv.Atoi(tt.bcryptCost); err == nil { expectedCost = costInt
expectedCost = costInt
}
} }
if cfg.App.BcryptCost != expectedCost { if cfg.App.BcryptCost != expectedCost {
t.Fatalf("expected BCRYPT_COST %d, got %d", expectedCost, cfg.App.BcryptCost) t.Fatalf("expected BCRYPT_COST %d, got %d", expectedCost, cfg.App.BcryptCost)