test: replace cached search dummy setup with dataclass fixture object

tests/test_app_filter.py

@@ -1,5 +1,8 @@
 from __future__ import annotations
 
+from dataclasses import dataclass, field
+from typing import Any, cast
+
 from auditui.app import Auditui
 from auditui.search_utils import build_search_text, filter_items
 
@@ -12,16 +15,17 @@ class StubLibrary:
         return item.get("authors", "")
 
 
-def test_get_search_text_is_cached() -> None:
-    class Dummy:
-        def __init__(self) -> None:
-            self._search_text_cache: dict[int, str] = {}
-            self.library_client = StubLibrary()
+@dataclass(slots=True)
+class Dummy:
+    _search_text_cache: dict[int, str] = field(default_factory=dict)
+    library_client: StubLibrary = field(default_factory=StubLibrary)
 
+
+def test_get_search_text_is_cached() -> None:
     item = {"title": "Title", "authors": "Author"}
     dummy = Dummy()
-    first = Auditui._get_search_text(dummy, item)
-    second = Auditui._get_search_text(dummy, item)
+    first = Auditui._get_search_text(cast(Auditui, dummy), item)
+    second = Auditui._get_search_text(cast(Auditui, dummy), item)
     assert first == "title author"
     assert first == second
     assert len(dummy._search_text_cache) == 1
@@ -38,7 +42,7 @@ def test_filter_items_uses_cache() -> None:
     def cached(item: dict) -> str:
         cache_key = id(item)
         if cache_key not in cache:
-            cache[cache_key] = build_search_text(item, library)
+            cache[cache_key] = build_search_text(item, cast(Any, library))
         return cache[cache_key]
 
     result = filter_items(items, "beta", cached)

tests/test_library.py

@@ -1,12 +1,14 @@
+from dataclasses import dataclass, field
+
 from auditui.library import LibraryClient
 
 
+@dataclass(slots=True)
 class MockClient:
-    def __init__(self) -> None:
-        self.put_calls: list[tuple[str, dict]] = []
-        self.post_calls: list[tuple[str, dict]] = []
-        self._post_response: dict = {}
-        self.raise_on_put = False
+    put_calls: list[tuple[str, dict]] = field(default_factory=list)
+    post_calls: list[tuple[str, dict]] = field(default_factory=list)
+    _post_response: dict = field(default_factory=dict)
+    raise_on_put: bool = False
 
     def put(self, path: str, body: dict) -> dict:
         if self.raise_on_put:

tests/test_table_utils.py

@@ -1,3 +1,6 @@
+from dataclasses import dataclass
+from typing import Any, cast
+
 from auditui import table_utils
 
 
@@ -25,9 +28,9 @@ class StubLibrary:
         return item.get("asin")
 
 
+@dataclass(slots=True)
 class StubDownloads:
-    def __init__(self, cached: set[str]) -> None:
-        self._cached = cached
+    _cached: set[str]
 
     def is_cached(self, asin: str) -> bool:
         return asin in self._cached
@@ -63,7 +66,7 @@ def test_format_item_as_row_with_downloaded() -> None:
         "asin": "ASIN123",
     }
     title, author, runtime, progress, downloaded = table_utils.format_item_as_row(
-        item, library, downloads
+        item, library, cast(Any, downloads)
     )
     assert title == "Title"
     assert author == "Author One"

tests/test_ui_email.py

@@ -1,4 +1,5 @@
 import json
+from dataclasses import dataclass, field
 from pathlib import Path
 
 import pytest
@@ -6,13 +7,13 @@ import pytest
 from auditui import ui
 
 
+@dataclass(slots=True)
 class DummyApp:
-    def __init__(self) -> None:
-        self.client = None
-        self.auth = None
-        self.library_client = None
-        self.all_items = []
-        self.BINDINGS = []
+    client: object | None = None
+    auth: object | None = None
+    library_client: object | None = None
+    all_items: list[dict] = field(default_factory=list)
+    BINDINGS: list[tuple[str, str, str]] = field(default_factory=list)
 
 
 @pytest.fixture