From eaa1628fccacaa746f6b067f3f53f3cf2b38ee91 Mon Sep 17 00:00:00 2001
From: Kharec <sandro@cazzaniga.fr>
Date: Sat, 3 Jan 2026 11:14:43 +0100
Subject: [PATCH] refactor: extract key display mapping and helper methods

---
 auditui/ui.py | 47 ++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 36 insertions(+), 11 deletions(-)

diff --git a/auditui/ui.py b/auditui/ui.py
index c065caa..68c943f 100644
--- a/auditui/ui.py
+++ b/auditui/ui.py
@@ -6,28 +6,53 @@ from textual.screen import ModalScreen
 from textual.widgets import Static
 
 
+KEY_DISPLAY_MAP = {
+    "ctrl+": "^",
+    "left": "←",
+    "right": "→",
+    "up": "↑",
+    "down": "↓",
+    "space": "Space",
+    "enter": "Enter",
+}
+
+KEY_COLOR = "#f9e2af"
+
+
 class HelpScreen(ModalScreen):
     """Help screen displaying all available keybindings."""
 
     BINDINGS = [("escape", "dismiss", "Close"), ("?", "dismiss", "Close")]
 
+    @staticmethod
+    def _format_key_display(key: str) -> str:
+        """Format a key string for display with symbols."""
+        result = key
+        for old, new in KEY_DISPLAY_MAP.items():
+            result = result.replace(old, new)
+        return result
+
+    @staticmethod
+    def _parse_binding(binding: tuple | object) -> tuple[str, str]:
+        """Extract key and description from a binding."""
+        if isinstance(binding, tuple):
+            key, _, description = binding
+        else:
+            key = binding.key
+            description = binding.description
+        return key, description
+
     def compose(self) -> ComposeResult:
         with Container(id="help_container"):
             yield Static("Key Bindings", id="help_title")
             with ScrollableContainer(id="help_content"):
-                bindings = self.app.BINDINGS
-                for binding in bindings:
-                    if isinstance(binding, tuple):
-                        key, action, description = binding
-                    else:
-                        key = binding.key
-                        description = binding.description
-                    key_display = key.replace(
-                        "ctrl+", "^").replace("left", "←").replace("right", "→").replace("up", "↑").replace("down", "↓").replace("space", "Space").replace("enter", "Enter")
+                for binding in self.app.BINDINGS:
+                    key, description = self._parse_binding(binding)
+                    key_display = self._format_key_display(key)
                     with Horizontal(classes="help_row"):
-                        yield Static(f"[bold #f9e2af]{key_display}[/]", classes="help_key")
+                        yield Static(f"[bold {KEY_COLOR}]{key_display}[/]", classes="help_key")
                         yield Static(description, classes="help_action")
-            yield Static("Press [bold #f9e2af]?[/] or [bold #f9e2af]Escape[/] to close", id="help_footer")
+            yield Static(f"Press [bold {KEY_COLOR}]?[/] or [bold {KEY_COLOR}]Escape[/] to close", id="help_footer")
 
     def action_dismiss(self) -> None:
         self.dismiss()